Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add LTS node version (16) to acceptable engines. #171

Merged
merged 5 commits into from
Mar 12, 2023

Conversation

johnschult
Copy link
Contributor

Node 16 is now LTS. This broke our build since we use the node:lts-alpine docker image.

@sounisi5011
Copy link
Owner

Sorry I left this up for so long!
The CI for this project is probably already broken; we will merge and release it after we fix the CI.

Copy link
Owner

@sounisi5011 sounisi5011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cannot be merged for the following reasons:

  • README.md file has not been updated

    In this repository, README.md files are automatically generated from .template/readme.njk.
    When you change the engines field, the contents of the README.md file should also be automatically updated.
    However, the README.md file is not updated in this PR.
    Probably because you did not execute the npm install command.

    You need to commit the updated README.md file by doing the following:

    1. Install Node.js

    2. Run the npm install command in the root directory of this repository

    3. Run the npm run build:readme command in this repository

    4. Commit updated README.md file

      Note
      I would recommend adding the --no-verify option to the git commit command.
      This is because the husky that runs at commit time probably doesn't work.
      We intend to update the dependencies to resolve this issue, but you may have started working on it before that update is synced to your repository.

  • Node.js 16 has not been tested on CI

    This project has not yet been unit tested on Node.js 16.
    We cannot add untested versions to the support range (i.e. the value of the engines.node field).
    CI settings need to be updated to support Node.js 16.

The CI settings can be updated by us.
Modify it to automatically run unit tests based on the value of the engines.node field.

Modified by #184

However, the README.md file needs to be updated by you.
Because I don't know how to add a commit to this PR.

If I can find a way to add a commit to this PR I will update the README.md file.
But if there is no way to do that, this PR cannot be merged until you update README.md file.

Edited by 0b95ebd

@sounisi5011 sounisi5011 changed the title Add LTS node version (16) to acceptable engines. ✨ Add LTS node version (16) to acceptable engines. Mar 12, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 12, 2023

Code Climate has analyzed commit 4c26057 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@sounisi5011 sounisi5011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Successfully tested with Node.js v16
  • The README.md file has been updated
  • Updated CHANGELOG

@sounisi5011 sounisi5011 merged commit 3c047a8 into sounisi5011:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants