-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add LTS node version (16) to acceptable engines. #171
Conversation
Sorry I left this up for so long! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR cannot be merged for the following reasons:
-
README.md
file has not been updatedIn this repository,
README.md
files are automatically generated from.template/readme.njk
.
When you change theengines
field, the contents of theREADME.md
file should also be automatically updated.
However, theREADME.md
file is not updated in this PR.
Probably because you did not execute thenpm install
command.You need to commit the updated
README.md
file by doing the following:-
Install Node.js
-
Run the
npm install
command in the root directory of this repository -
Run the
npm run build:readme
command in this repository -
Commit updated
README.md
fileNote
I would recommend adding the--no-verify
option to thegit commit
command.
This is because the husky that runs at commit time probably doesn't work.
We intend to update the dependencies to resolve this issue, but you may have started working on it before that update is synced to your repository.
-
-
Node.js 16 has not been tested on CIThis project has not yet been unit tested on Node.js 16.
We cannot add untested versions to the support range (i.e. the value of theengines.node
field).
CI settings need to be updated to support Node.js 16.
The CI settings can be updated by us.
Modify it to automatically run unit tests based on the value of the engines.node
field.
Modified by #184
However, the README.md
file needs to be updated by you.
Because I don't know how to add a commit to this PR.
If I can find a way to add a commit to this PR I will update the README.md
file.
But if there is no way to do that, this PR cannot be merged until you update README.md
file.
Edited by 0b95ebd
Code Climate has analyzed commit 4c26057 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Successfully tested with Node.js v16
- The
README.md
file has been updated - Updated CHANGELOG
Node 16 is now LTS. This broke our build since we use the
node:lts-alpine
docker image.