Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Migrate from CommonJS to ESM #227

Merged
merged 9 commits into from
Apr 2, 2023
Merged

♻️ Migrate from CommonJS to ESM #227

merged 9 commits into from
Apr 2, 2023

Conversation

sounisi5011
Copy link
Owner

No description provided.

+ Add file extensions to the filepath in the import statement
+ Read the `package.json` file using the `readJSONFile()` function instead of the `require()` function
+ Use top-level await
+ Modified `readJSONFile()` and `relativePath()` functions to allow `URL` objects to be specified as arguments
+ Add file extensions to the filepath in the import statement
+ Use `import.meta.url` instead of `__dirname` variable
+ Fix type declarations in `is-promise` package
@sounisi5011 sounisi5011 marked this pull request as ready for review April 2, 2023 05:05
github-actions[bot]
github-actions bot previously approved these changes Apr 2, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 2, 2023

Code Climate has analyzed commit 5133c65 and detected 0 issues on this pull request.

View more on Code Climate.

@sounisi5011 sounisi5011 changed the title ✨ Migrate from CommonJS to ESM ♻️ Migrate from CommonJS to ESM Apr 2, 2023
@sounisi5011 sounisi5011 merged commit ca9dbb0 into master Apr 2, 2023
@sounisi5011 sounisi5011 deleted the move-to-esm branch April 2, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant