Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2 #43

Merged
merged 25 commits into from
Sep 12, 2021
Merged

Release 1.2 #43

merged 25 commits into from
Sep 12, 2021

Conversation

soup-bowl
Copy link
Owner

@soup-bowl soup-bowl commented Sep 12, 2021

Proposed merge in (launch) of version 1.2 of the simple SMTP plugin.

Brings the following changes (from the log):

  • New: Multisite settings for admin visibility and override settings (#6).
  • New: Sites in debug mode will show what stage has set the configuration item in the relevant box.
  • New: For sites using logging, 'Erase Personal Data' will remove requested email address entries from the log (#37).

This needs signficiant testing in the following areas:

  • Making sure the plugin still operates as expected on regular installations.
  • Testing out the Multisite overrides, and ensuring the option to disable features does not impact operation.
  • Check the erase data integration on normal and MS instances.

The Docker scripts have been updated to support quick instantiation into singular or multisite instances. This can be extended in the future to support quick setup instances.

@soup-bowl soup-bowl added the enhancement New feature or request label Sep 12, 2021
@soup-bowl soup-bowl added this to the Version 1.2 milestone Sep 12, 2021
@soup-bowl soup-bowl self-assigned this Sep 12, 2021
@soup-bowl
Copy link
Owner Author

No unit test changes/improvements. Will continue to test, but this will need to be refactored in the next release.

@soup-bowl soup-bowl added the help wanted Extra attention is needed label Sep 12, 2021
@soup-bowl
Copy link
Owner Author

soup-bowl commented Sep 12, 2021

Upon testing a MS instance, if you set a password and then try to save the settings on a child site, you will experience a post error.

To replicate:

  • Generate a MS instance, network activate the plugin.
  • In Network Mail, set a password (tool used in this was mailtrap.io).
  • Go into a child site SMTP settings.
  • Save the settings page.

This produces the error:

Notice: Undefined index: pass in /var/www/html/wp-content/plugins/simple-smtp/src/settings/class-singular.php on line 203

Edit: This appears to also occur when env or config is used, so not isolated. Potentially not a new bug.

Edit 2: Apologies, this isn't a stopping bug. Should've paid more attention, but it's a notice produced by the system that only appeared as an error to me due to debug mode being on. Will note this down, but this shouldn't stop the progress.

@soup-bowl soup-bowl removed the help wanted Extra attention is needed label Sep 12, 2021
@soup-bowl soup-bowl merged commit 9093cf0 into main Sep 12, 2021
@soup-bowl soup-bowl deleted the release-1.2 branch September 13, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant