Check if document is defined (SSR support)
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanenko
commented
Oct 12, 2017
| @@ -1,4 +1,8 @@ | |||
| export default (() => { | |||
| if (typeof document === 'undefined') { | |||
| return () => {} | |||
There was a problem hiding this comment.
I've decided to go with early return and no-op function here, because this function still expected to return some function anyway. Without document it is reasonable, that the resulting function could be simply empty
|
Thank you for this 🙏 also, I appreciate the kind words! 😊 |
This was referenced Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. First of all, thanks for the great and a pretty minimalistic lib. It is a rare case of a useful lib for React with just plain HOCs, a foundation, to be able to construct something completely custom.
I've added type checks for
documentobject in fullscreen functions make this library useful in SSR environments and toolkits like Gatsby, Next.js or Razzle.It should fix #26, #17, #31
I've tested my PR locally: with these changes it works fine server-side.