Create AudioContext in HTML5 vendor on componentDidMount #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,12 +3,8 @@ import PropTypes from 'prop-types' | |||
| import { findDOMNode } from 'react-dom' | |||
| import vendorPropTypes from './vendor-prop-types' | |||
|
|
|||
| const AudioContext = window.AudioContext || window.webkitAudioContext | |||
There was a problem hiding this comment.
I think we only need to change this line. Something like:
const AudioContext = typeof window === 'undefined' ? false : (window.AudioContext || window.webkitAudioContext)There was a problem hiding this comment.
Yes, that would work
There was a problem hiding this comment.
Awesome! If you get a chance and want to update this PR, I'll get it merged and released.
|
Sorry, this took a little while to get to. I think we can fix this with one-liner hopefully 🤞. Please see my comment where context is created. |
This reverts commit e38fa40.
|
Made the change |
|
Thank you!! 🙏 Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way you can import
Playerin SSR projects again, otherwise it crashes because there's nowindowin server side.