Upgrade to react 16 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephane Jolicoeur <sjolicoeur@pivotal.io>
Signed-off-by: Reid Mitchell <rmitchell@pivotal.io>
rafeememon
reviewed
Oct 3, 2017
package.json
Outdated
| @@ -34,8 +34,8 @@ | |||
| "tether": "^1.3.7" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "^0.14.0 || ^15.0.0", | |||
| "react-dom": "^0.14.0 || ^15.0.0" | |||
| "react": "^16.0.0", | |||
There was a problem hiding this comment.
Support for 0.14 and 15.x probably shouldn't be removed unless there is a breaking change
There was a problem hiding this comment.
@rafeememon ok will fix this ASAP.
…aking change Signed-off-by: Reid Mitchell <rmitchell@pivotal.io>
|
LGTM! |
|
Is there anything blocking this PR? |
|
@rafeememon we made the necessary change, is it possible to have the PR merged and a new release? |
|
Any update on this? |
|
It's not going to happen until #58 is fixed |
|
@souporserious are we really blocked on merging this because there isn't a new maintainer assigned yet? I just want to verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made changes to the package.json to allow react-tether to work with React v16.0.0
this should fix #56
PS: we aren't sure if the yarn.lock is necessary for the upgrade.