Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Remove deprecated propTypes usage to support React 15.5 #535

Closed
kevynb opened this issue Oct 19, 2017 · 4 comments
Closed

React: Remove deprecated propTypes usage to support React 15.5 #535

kevynb opened this issue Oct 19, 2017 · 4 comments

Comments

@kevynb
Copy link

kevynb commented Oct 19, 2017

Hello,

I'm getting the following warning when using the <OverlayTrigger> component:

lowPriorityWarning.js?d93c:40 Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs

It seems to be because this component uses the react-tether library in version 0.5.2 that still uses react.Proptypes. This behaviour was fixed in version 0.5.7.

Do you think an upgrade is possible?

Thanks!

@sjolicoeur
Copy link
Contributor

sjolicoeur commented Oct 19, 2017

@kevynb In which version of pivotal-ui are you seeing this issue?

@kevynb
Copy link
Author

kevynb commented Oct 20, 2017

I'm using npm package "pui-react-tooltip": "^8.3.3" which seems to be the latest version available on npm.

@sjolicoeur
Copy link
Contributor

@kevynb I see! Since version 9 we stopped publishing the individual components in a stand-alone manner, and are publishing them all under Pivotal-UI to get individual components now a simple import of the specific component is necessary. it also makes it easier for package.json maintenance

import {OverlayTrigger} from 'pivotal-ui/react/overlay-trigger';

Would you be able to upgrade to v9 at the very least? Or v10 would be the latest?

@kevynb
Copy link
Author

kevynb commented Oct 26, 2017

Hello,

I upgraded to version 9, since it seems I cannot use version 10 until we migrate to React 16.
It's indeed much easier to have them all in one package.

Thanks problem fixed!

@kevynb kevynb closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants