Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web vitals errors #51

Closed
TannerGabriel opened this issue Jul 18, 2021 · 2 comments
Closed

Web vitals errors #51

TannerGabriel opened this issue Jul 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@TannerGabriel
Copy link
Contributor

TannerGabriel commented Jul 18, 2021

First, thank you for all the work on the project. That said, I have found a few bugs/problems when running a website performance test that should be addressed.

Cross origin destination unsafe

This can be fixed by adding the named parameters to the a tag in this line. I could make a PR for this if that is ok with you.

The following error could be a bit harder to debug as it has something to do with WebSockets, but it is not easily reproducible when trying manually. Let me know if you have any ideas about this.

Socket errors

@souramoo souramoo added the enhancement New feature or request label Jul 27, 2021
@souramoo
Copy link
Owner

Hey,
Thanks for looking into this! I'd be more than happy to accept a PR for this :)

The websocket error is weird - I've tried to do a bit of research on it and it seems it's quite common and likely because the web.dev firewall blocks websocket connections during the test (https://stackoverflow.com/questions/59157106/unable-to-reproduce-web-dev-console-errors) but are safely ignored.

@TannerGabriel
Copy link
Contributor Author

@souramoo If we can safely ignore the WebSockets errors, I see no problem in closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants