Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update schema in README #1127

Merged
merged 1 commit into from
May 19, 2024

Conversation

GabrielCWT
Copy link
Contributor

This PR updates the schema.png in the README to reflect new tables and columns, e.g. teams and team_members tables

@GabrielCWT GabrielCWT self-assigned this May 19, 2024
@coveralls
Copy link

Coverage Status

coverage: 95.295%. remained the same
when pulling 9b62ada on GabrielCWT:docs/update-schema
into 060355c on source-academy:master.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I think it makes sense to remove the constraints and the types from the diagram as we are interested in mainly the relationships between the various tables as opposed to the internal implementation; one can always just look at the DB to find out what the enforced constraints/types are.

LGTM!

@RichDom2185 RichDom2185 merged commit 812056c into source-academy:master May 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants