Remove frontend #32
Merged
Remove frontend #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 121
💛 - Coveralls |
evansb
requested changes
May 19, 2018
lib/cadet_web/router.ex
Outdated
| pipeline :browser do | ||
| plug(:accepts, ["html"]) | ||
| pipeline :api do | ||
| plug(:accepts, ["json"]) | ||
| plug(:fetch_session) | ||
| plug(:fetch_flash) | ||
| plug(:protect_from_forgery) |
There was a problem hiding this comment.
I don't think you need CSRF protection since cookies is not used
lib/cadet_web/router.ex
Outdated
| pipeline :browser do | ||
| plug(:accepts, ["html"]) | ||
| pipeline :api do | ||
| plug(:accepts, ["json"]) | ||
| plug(:fetch_session) | ||
| plug(:fetch_flash) |
There was a problem hiding this comment.
This shouldn't be needed anymore
indocomsoft
force-pushed
the
remove-frontend
branch
from
171f0b7
to
d88bf50
Compare
indocomsoft
force-pushed
the
remove-frontend
branch
from
6741360
to
7bf9a25
Compare
|
@evansb Done :) |
evansb
approved these changes
May 20, 2018
|
@indocomsoft can you make a separate PR to set code coverage back to 98-100 percent? remove all dead code, and #26 |
|
Will do. #33 is one attempt to. |
indocomsoft
added a commit
that referenced
this pull request
Aug 17, 2018
* Remove frontend stuffs * Remove frontend config * Change router * Remove failing tests * Remove unnecessary plugs in router * Revert wrongfully removed conflict resolution * Remove failing test * Run mix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27