-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove frontend #32
Remove frontend #32
Conversation
Pull Request Test Coverage Report for Build 121
💛 - Coveralls |
lib/cadet_web/router.ex
Outdated
pipeline :browser do | ||
plug(:accepts, ["html"]) | ||
pipeline :api do | ||
plug(:accepts, ["json"]) | ||
plug(:fetch_session) | ||
plug(:fetch_flash) | ||
plug(:protect_from_forgery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need CSRF protection since cookies is not used
lib/cadet_web/router.ex
Outdated
pipeline :browser do | ||
plug(:accepts, ["html"]) | ||
pipeline :api do | ||
plug(:accepts, ["json"]) | ||
plug(:fetch_session) | ||
plug(:fetch_flash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be needed anymore
171f0b7
to
d88bf50
Compare
6741360
to
7bf9a25
Compare
@evansb Done :) |
@indocomsoft can you make a separate PR to set code coverage back to 98-100 percent? remove all dead code, and #26 |
Will do. #33 is one attempt to. |
* Remove frontend stuffs * Remove frontend config * Change router * Remove failing tests * Remove unnecessary plugs in router * Revert wrongfully removed conflict resolution * Remove failing test * Run mix format
Fixes #27