Reset errors after validateAndAnnotate instead

[openorclose]

Evaluator: Reset errors after validateAndAnnotate instead

Summary: Fixes issue #1174.

Description

Type-validation and annotation, or evaluation of a Source program, can both produce errors. This results in duplicate errors for certain Source programs when the errors from the evaluation are not preserved correctly.

To fix this, we specifically preserve only the errors (in red below) from evaluating the Source program, and use it to override the errors from type-validation and annotation. Any hints (in gray below) generated by type-validation and annotation are still preserved.

Changelog

• Reset errors after validating and annotating Source program

Verification instructions

1. Attempt to evaluate this program in the Playground editor

   const y = x;
   y = 2;

2. Evaluation should result in only one error and one hint as shown in the second screenshot above

Last updated 10 Jun 2020, 1:00AM

[coveralls]

Pull Request Test Coverage Report for Build 5333

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 34.031%

---

Totals
Change from base Build 5330:	0.0%
Covered Lines:	1698
Relevant Lines:	4621

---

💛 - Coveralls

[Aulud]

Nice 👍 - this fixes the issue; will clean up the PR and test it more thoroughly before getting one of the team members to review it.

[Aulud]

Fix works without introducing other errors when manually tested.