Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: improves hotkeys #1817

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Stepper: improves hotkeys #1817

merged 3 commits into from
Jun 21, 2021

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Jun 21, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Go here
https://b8be6114.cadet-frontend.pages.dev
and play with the stepper:
a: Move to the first step
e: Move to the last step
f: Move to the next step
b: Move to the previous step

Note that these shortcuts are only active when the browser focus is on the stepper tab (click on or above the explanation text).

Checklist

  • I have tested this code
  • I have updated the documentation

@martin-henz martin-henz changed the title Hotkeys Stepper: improves hotkeys; fixes #1751 Jun 21, 2021
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 21, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e165b1
Status: ✅  Deploy successful!
Preview URL: https://b8be6114.cadet-frontend.pages.dev

View logs

@coveralls
Copy link

coveralls commented Jun 21, 2021

Pull Request Test Coverage Report for Build 957617377

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 30.073%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sideContent/SideContentSubstVisualizer.tsx 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/commons/sideContent/SideContentSubstVisualizer.tsx 1 1.62%
Totals Coverage Status
Change from base Build 957608250: -0.01%
Covered Lines: 3208
Relevant Lines: 9826

💛 - Coveralls

@martin-henz martin-henz changed the title Stepper: improves hotkeys; fixes #1751 Stepper: improves hotkeys Jun 21, 2021
@martin-henz martin-henz merged commit e7dd729 into master Jun 21, 2021
@jiayushe jiayushe deleted the hotkeys branch September 7, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants