Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary spans from sicpjs #1824

Merged
merged 6 commits into from
Jun 26, 2021
Merged

Remove unnecessary spans from sicpjs #1824

merged 6 commits into from
Jun 26, 2021

Conversation

samuelfangjw
Copy link
Contributor

Description

Removed unnecessary spans.
Before:
Screenshot 2021-06-24 at 3 14 47 PM

After:
Screenshot 2021-06-24 at 3 14 32 PM

Will find some time to work on accessibility issues in the future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@martin-henz martin-henz requested a review from angelsl June 24, 2021 07:40
@coveralls
Copy link

coveralls commented Jun 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 973533991

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 30.046%
Totals Coverage Status
Change from base Build 973532208: 0.03%
Covered Lines: 3203
Relevant Lines: 9818
💛 - Coveralls

@martin-henz martin-henz self-requested a review June 26, 2021 06:12
martin-henz
martin-henz approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@martin-henz martin-henz merged commit 1341832 into source-academy:master Jun 26, 2021
@samuelfangjw samuelfangjw deleted the remove-unnecesary-spans branch June 26, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@angelsl angelsl Awaiting requested review from angelsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelfangjw @coveralls @martin-henz