Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade konva to latest version #2044

Merged
merged 10 commits into from
Jan 5, 2022
Merged

Conversation

ngxingyu
Copy link
Contributor

@ngxingyu ngxingyu commented Dec 30, 2021

Description

  • Upgrade konva from ^7.2.5 → ^8.3.1
  • Fix target type for setHoveredStyle and setUnhoveredStyle from Node to Node | Group
  • Replaced "jest-canvas-mock": "^2.3.1" with "canvas": "^2.8.0" to allow the canvas to be mocked properly (Doesn't work with latest Create React App hustcc/jest-canvas-mock#72)
  • Removed "konva-node": "^0.11.2" (not needed as of konva 8.0.0)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Existing tests for Env Visualizer passes, sample code diagrams looks the same

Checklist

  • I have tested this code

@coveralls
Copy link

coveralls commented Dec 30, 2021

Pull Request Test Coverage Report for Build 1639759619

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 31.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/envVisualizer/EnvVisualizerUtils.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 1639740784: 0.09%
Covered Lines: 3481
Relevant Lines: 10454

💛 - Coveralls

Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with the migration!

@chownces chownces merged commit f8b3fa5 into master Jan 5, 2022
@chownces chownces deleted the xingyu/upgrade_konva_version branch January 5, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants