Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toggle Folder mode control bar button not having a key #2387

Merged
merged 2 commits into from Mar 26, 2023
Merged

Fix toggle Folder mode control bar button not having a key #2387

merged 2 commits into from Mar 26, 2023

Conversation

ianyong
Copy link
Member

@ianyong ianyong commented Mar 24, 2023 •
edited

Description

Resolves the following warning in console:

Warning: Each child in a list should have a unique "key" prop

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Check that the warning no longer appears in the console.

@ianyong ianyong requested a review from zhaojj2209 March 24, 2023 12:03
@ianyong ianyong changed the title Fix folder toggle control bar button not having a key Fix toggle Folder mode control bar button not having a key Mar 24, 2023
@coveralls
Copy link

coveralls commented Mar 24, 2023 •
edited

Pull Request Test Coverage Report for Build 4522483781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.029%
Totals Coverage Status
Change from base Build 4522480025: 0.0%
Covered Lines: 4726
Relevant Lines: 12570
💛 - Coveralls

@ianyong ianyong enabled auto-merge (squash) March 26, 2023 02:57
@ianyong ianyong merged commit 329c8d2 into master Mar 26, 2023
1 check passed
@ianyong ianyong deleted the fix-folder-control-bar-button-not-having-key branch March 26, 2023 03:04
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Jul 15, 2023
@ianyong @RichDom2185
Fix folder toggle control bar button not having a key (source-academy…
c96b1b0 
…#2387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianyong @coveralls @zhaojj2209