Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modules on c #2939

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix modules on c #2939

merged 1 commit into from
Apr 15, 2024

Conversation

benmurphyy
Copy link
Contributor

Description

Fixes an issue with importing source academy modules into C

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested this code

@benmurphyy benmurphyy self-assigned this Apr 15, 2024
@benmurphyy benmurphyy added the Bug Something isn't working label Apr 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8688294331

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 33.084%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/utils/CToWasmHelper.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 8682515461: 0.002%
Covered Lines: 5277
Relevant Lines: 14842
💛 - Coveralls

martin-henz
martin-henz approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-henz martin-henz merged commit 68ad33e into master Apr 15, 2024
8 checks passed
@martin-henz martin-henz deleted the fix-c-modules branch April 15, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

Assignees

@benmurphyy benmurphyy

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benmurphyy @coveralls @martin-henz