Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tree.js, update index.ts #32

Merged
merged 2 commits into from
Sep 14, 2018
Merged

add tree.js, update index.ts #32

merged 2 commits into from
Sep 14, 2018

Conversation

lywjoel
Copy link
Contributor

@lywjoel lywjoel commented Sep 14, 2018

No description provided.

@coveralls
Copy link

coveralls commented Sep 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 114

  • 1 of 12 (8.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 32.762%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tree.js 0 11 0.0%
Totals Coverage Status
Change from base Build 112: -0.2%
Covered Lines: 947
Relevant Lines: 2769
💛 - Coveralls

remo5000
remo5000 requested changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@remo5000 remo5000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add tree.js to the build script? scripts/build.sh

remo5000
remo5000 approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remo5000 remo5000 merged commit 687432a into source-academy:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remo5000 remo5000 remo5000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lywjoel @coveralls @remo5000