Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing unicode errors in build: more fixes needed #1701

Merged
merged 6 commits into from
May 6, 2024
Merged

Conversation

martin-henz
Copy link
Member

No description provided.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to be missing the leading backslashes of \Theta and \Omega.

Can we also add a check to the CI workflow?

@coveralls
Copy link

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8966713762

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.112%

Totals Coverage Status
Change from base Build 8938442915: 0.0%
Covered Lines: 10930
Relevant Lines: 12966

💛 - Coveralls

@martin-henz
Copy link
Member Author

martin-henz commented Apr 29, 2024

We seem to be missing the leading backslashes of \Theta and \Omega.

Can we also add a check to the CI workflow?

We seem to be missing the leading backslashes of \Theta and \Omega.

Can we also add a check to the CI workflow?

The backslashes wouldn't lead to a good output. We could escape these things by saying ^$\Theta$^ to get a nice PDF.

But then the json output for autocomplete would look really ugly (unless we do some more magic). Also jsdoc would look bad.

So at the moment, docs/lib/list.js is used for:

  • PDF
  • jsdocs
  • autocomplete

and we just tolerate a "Theta" appearing everywhere, to keep things simple.

@RichDom2185
Copy link
Member

RichDom2185 commented Apr 29, 2024

We seem to be missing the leading backslashes of \Theta and \Omega.

Can we also add a check to the CI workflow?

Hi Prof @martin-henz, I've fixed these, though I can't check as I don't have LaTeX installed locally. Could you verify that it's correct now?

Edit: Didn't see the above comment

@RichDom2185
Copy link
Member

So at the moment, docs/lib/list.js is used for:

  • PDF
  • jsdocs
  • autocomplete

and we just tolerate a "Theta" appearing everywhere, to keep things simple.

Replacing Θ with &#1012 works nicely in JSDoc. How about the others?

@martin-henz
Copy link
Member Author

So at the moment, docs/lib/list.js is used for:

  • PDF
  • jsdocs
  • autocomplete

and we just tolerate a "Theta" appearing everywhere, to keep things simple.

Replacing Θ with &#1012 works nicely in JSDoc. How about the others?

The file list.js is currently attached verbatim (using lstlisting in LaTeX) to source_2.pdf.

That means it will look ugly (illegible).

On the longer run, we should find a way to attach list.js in a nicer way to source_2.pdf.

I suggest we go ahead with just "Theta" (and make an issue) for now.

@RichDom2185
Copy link
Member

I suggest we go ahead with just "Theta" (and make an issue) for now.

Made the issue in #1705

@RichDom2185 RichDom2185 enabled auto-merge (squash) May 6, 2024 09:08
@RichDom2185 RichDom2185 merged commit cb2e6fc into master May 6, 2024
4 checks passed
@RichDom2185 RichDom2185 deleted the unicode2 branch May 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants