Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation of parser function in Source 4 #365

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Conversation

martin-henz
Copy link
Member

adds documentation of parse function in Source §4

@coveralls
Copy link

coveralls commented Oct 31, 2019

Pull Request Test Coverage Report for Build 1769

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.791%

Totals Coverage Status
Change from base Build 1751: 0.0%
Covered Lines: 2175
Relevant Lines: 2386

💛 - Coveralls

Copy link
Member

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to build this, the margins seem to be set weirdly and the code goes off screen:
maim9981
Do you know what's going on?

@martin-henz
Copy link
Member Author

I use a package called typearea, and put these two pages in landscape mode so that the righthand column fits onto the page. Maybe a version issue with your LaTeX?

I've installed the result already here:
https://sicp.comp.nus.edu.sg/source/source_4.pdf

Can you compare the result of your built with the installed version?

Copy link
Member

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor bugs but should be good afterwards.

doc/source_interpreter.tex Outdated Show resolved Hide resolved
doc/source_interpreter.tex Outdated Show resolved Hide resolved
doc/source_interpreter.tex Outdated Show resolved Hide resolved
doc/source_interpreter.tex Outdated Show resolved Hide resolved
doc/source_interpreter.tex Show resolved Hide resolved
doc/source_interpreter.tex Outdated Show resolved Hide resolved
Copy link
Member

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-henz martin-henz merged commit 9e505b4 into master Nov 4, 2019
@thomastanck thomastanck deleted the parser-doc branch August 1, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants