Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON: Simplify container tags + minor fixes #533

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

samuelfangjw
Copy link
Contributor

@samuelfangjw samuelfangjw commented Jun 16, 2021

  1. Rename ref names for consistency (standardise all _ to be -)
  2. Clean up metaphrase tag. Currently, langle and rangle are added on the frontend. This PR moves the addition of langle and rangle to the sicp repo instead.
  3. Simplify parsing of "container tags", defined as elements that have a title and children elements. Rationale: these are all parsed in the same manner on the frontend. This PR changes the JSON tag of all elements with similar behaviour to SECTION to the SECTION tag (e.g. SUBSECTION now tagged as SECTION in JSON files).

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@martin-henz martin-henz merged commit 453a403 into source-academy:master Jun 16, 2021
@samuelfangjw samuelfangjw deleted the simiplify-containers branch June 16, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants