Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box glyphs don't close vertically #41

Closed
gavineadie opened this issue Aug 31, 2015 · 10 comments
Closed

Box glyphs don't close vertically #41

gavineadie opened this issue Aug 31, 2015 · 10 comments

Comments

@gavineadie
Copy link

The box glyphs don't form continuous vertical lines .. horizontals are OK. Note the gaps in the vertical lines below (from Xcode). Menlo, SourceCodePro and other "coding" fonts get it right:

screenshot 2015-08-31 00 28 40

@gavineadie
Copy link
Author

.. on the other hand, subscripts do look nice:

screenshot 2015-08-31 00 49 15

@chrissimpkins
Copy link
Member

The box glyphs don't form continuous lines

Mind giving this same block of text a try with this test version that uses tighter vertical spacing? It is renamed 'Hack Tight' so that it can be installed along with the release version.

https://github.com/chrissimpkins/Hack/blob/vertical-spacing/build/test_builds/HackTight-Regular-h.ttf

I'll take a look at the position of the glyphs to confirm that this isn't an alignment issue with the glyphs themselves rather than a line spacing issue.

@gavineadie
Copy link
Author

It's a little tighter, but doesn't close the gap. I do prefer the slightly tighter spacing though:

screenshot 2015-08-31 10 39 45

@chrissimpkins
Copy link
Member

Close but no cigar. OK, probably in the glyphs themselves. Going to shelve this until I get the vertical spacing issues sorted out or else we would redo it anyways. Will get back on it once I have a stable set of vertical metrics to work with. Will be releasing at least one tighter vert spacing version along with the current spacing down the road. Will let you know when ready.

@msharov
Copy link

msharov commented Sep 3, 2015

Other double line joints also do not quite line up, with ╩ ═ ╧ being a pixel lower than ╔ ╦. I'm using 16 point Hack-Regular.

@chrissimpkins
Copy link
Member

Vertical metrics were updated across the entire font with significantly tighter vertical spacing. Mind giving these fonts a try and let me know how close we are on these glyphs? Thanks.

Available in #111

@gavineadie
Copy link
Author

Looks good
screenshot 2015-09-21 10 31 14

Note, I'm not using the 'junction' glyphs (mentioned by @msharov), just the 'straights' and 'corners' .. Thanks for your work on this.

@chrissimpkins
Copy link
Member

Fantastic. My original vertical metrics changes led to these problems. We have requests for looser spacing variants so we will need to address this down the line. Thank you very much for looking into this issue again.

@chrissimpkins
Copy link
Member

I will close this issue when we release these changes unless you have any other associated alignment concerns.

Await feedback from @msharov about the other glyph set and will open a separate issue if this is not addressed.

@chrissimpkins
Copy link
Member

These vertical spacing changes are now included in v2.015. Thank you very much for the issue report and the testing that you performed on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants