Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger and smaller vertical spacing variants #28

Closed
chrissimpkins opened this issue Aug 29, 2015 · 43 comments
Closed

Larger and smaller vertical spacing variants #28

chrissimpkins opened this issue Aug 29, 2015 · 43 comments
Assignees

Comments

@chrissimpkins
Copy link
Member

By request. Will add these to the development branch for anyone who wants to give them a try.

@chrissimpkins chrissimpkins changed the title Wider and narrower vertical spacing versions Larger and smaller vertical spacing variants Aug 29, 2015
@Palid
Copy link

Palid commented Aug 30, 2015

Count me in, will test narrower vertical spacing.

@txtsd
Copy link

txtsd commented Aug 30, 2015

I would like narrower vertical spacing too!
My PS1 has a vertical gap, and irc in terminal looks too spaced out between lines.
DejaVu Sans Mono - DejaVu Sans Mono 7pt
Hack - Hack 7pt

@chrissimpkins
Copy link
Member Author

Mind giving this test build a try to see what you think of the spacing? The font name was changed to 'Hack Tight' so that you can install it with the current release of Hack and compare the two. When we hit a sweet spot with the spacing, I will build the rest of the sets.

https://github.com/chrissimpkins/Hack/blob/vertical-spacing/build/test_builds/HackTight-Regular-h.ttf

Changes:
TypoLineGap decreased to 75 units
LineGap decreased to 75 units

@theckman
Copy link

I think it looks nice.

Hack:
Hack

Hack Tight:
Hack Tight

Edit Menlo for Powerline:
Menlo for Powerline

@chrissimpkins
Copy link
Member Author

worth going even tighter? we could release a range. the diacritics are still visible with this spacing.

any interest in wider spacing for any layout issues out there?

@theckman
Copy link

It is an improvement, but I think it could go a bit tighter, yes. This is what I came from:

Menlo for Powerline

@hrj
Copy link

hrj commented Aug 31, 2015

Check out the ASCII art in the following screenshot, comparing Fantasque with Hack and Hack Tight. The gap between the vertical bars is the same between Hack and Hack Tight. In Fantasque, the vertical line doesn't have a gap.

hackfont

@hrj
Copy link

hrj commented Aug 31, 2015

Oh btw, here's the ASCII if you need to reproduce the issue:

  -2600.00   Expenses        
   -200.00    ├╴Bank_Charges 
   -400.00    ├╴Consumables  
  -2000.00    └╴Salaries     

@txtsd
Copy link

txtsd commented Aug 31, 2015

Not sure what's going on, but my Hack OTF v2.010 shows as thinner than Hack TTF v2.010, and the Hack Tight TTF is not different from Hack TTF.

Hack gif

@txtsd
Copy link

txtsd commented Aug 31, 2015

fc-match reports correctly (I uninstalled the otf)

┌[txtsd@dungeon-of-data]─[~] 
└─▶ fc-match "Hack Tight"
HackTight-Regular-h.ttf: "Hack Tight" "Regular"

┌[txtsd@dungeon-of-data]─[~] 
└─▶ fc-match "Hack"      
Hack-Regular.ttf: "Hack" "Regular"

@chethankumar
Copy link

I also would prefer if it was a little bit more tighter. As tight as, say Monaco.

@chrissimpkins
Copy link
Member Author

@hrj it looks like this is a glyph alignment issue. This was reported for box glyphs in #41 as well and the Hack Tight build didn't help there either. I will tackle the spacing with these glyphs that require alignment with each other once we hammer out a final set of vertical metrics.

@rdlugosz
Copy link

rdlugosz commented Sep 1, 2015

I'd also submit Menlo as a good example of a tight line height. For relative comparison, with Menlo 12pt I can see 96 lines in MacVim. Using Hack at 12pt that drops to just 78, a full 18 fewer lines. Probably doesn't need to get that tight, but should head in that direction in the tight and clown-car tight variants.

@chrissimpkins
Copy link
Member Author

clown-car tight...

I think that you just named it :)

I am going to try to push a few more builds with some adjustments to the vertical metrics later today. I will take a look at Menlo's metrics and see how close we can get without taking out the diacritics.

@rdlugosz
Copy link

rdlugosz commented Sep 2, 2015

👍

@Binarytales
Copy link

There's been a lot of discussion of of tight line spacing here but I was wondering if there are still plans for wider line spacing variants as mentioned in the title?

I currently use Meslo on the cmd line (a variant of Menlo with variable line heights) https://github.com/andreberg/Meslo-Font

I'm a big fan of the largest spacing. Terminal.app and iTerm2 on OSX (which probably account for 90% of cmd line use on OSX allow for increasing line height in preferences. I don't know if other platforms have such features. But the problem with relying on this is that the Powerline icons (mainly the section separators) start to look bad and stop lining up as intended when line height is adjusted in this way.

@chrissimpkins
Copy link
Member Author

@Binarytales most have requested tighter spacing but I planned to create looser spacing as well. I began working on this last night. Stay tuned.

@Binarytales
Copy link

@chrissimpkins I shall indeed stay tuned. More than happy to test things out when you have something ready.

@rdlugosz
Copy link

rdlugosz commented Sep 5, 2015

@chrissimpkins - check out the detail the creator of the "Input" font goes into wrt variants, size, heights, etc. Much of this is beyond my understanding of font creation, but might be helpful to you. Seems like they have incorporated a wide variety of options here. http://input.fontbureau.com/info/

@chrissimpkins
Copy link
Member Author

@rdlugosz Input is a fantastic typeface and hard act to follow. They've put a tremendous amount of thought and effort into it. Thanks for linking the information on their design considerations.

@chrissimpkins
Copy link
Member Author

It's become apparent that this will be a bit larger project than I initially thought because we will need to address spacing issues in all of the glyphs that require exact alignment/orientation with each other (eg the box glyphs).

@rdlugosz
Copy link

rdlugosz commented Sep 7, 2015

Ah that's a bummer. Well, if someone out there is motivated to have tighter
lines and has the skills + time to spare perhaps they'll contribute. Thanks
for looking into it!

On Monday, September 7, 2015, Chris Simpkins notifications@github.com
wrote:

It's become apparent that this will be a bit larger project than I
initially thought because we will need to address spacing issues in all of
the glyphs that require exact alignment/orientation with each other (eg the
box glyphs).


Reply to this email directly or view it on GitHub
#28 (comment).

@chrissimpkins
Copy link
Member Author

Not writing it off at all. It's in the queue. We will just need to be prepared to address issues with all of these glyphs to make a version that contains the current character set support happen.

One approach would be to start with narrower character set support and expand this over time. This would initially exclude glyphs that require exact vertical alignment with each other. Anyone in favor of this? Anyone forsee other problems that I am overlooking with the vertical spacing?

@chrissimpkins
Copy link
Member Author

The version 2.014 test build has tighter line spacing, in line with the line spacing in DejaVu Sans Mono and Menlo. I get the same number of lines as are displayed with these two fonts now. We've had a number of issue reports about very slight vertical alignment issues between sets that prompted this vertical metrics update. For those who like it tight, you will likely find this build to your liking. I am waiting for more general feedback to decide if this will be the new default. I anticipate that this is going to address some of our Powerline and other alignment dependent spacing issues so this may well stick.

Files are available in #111

For those looking for looser builds, this is still planned.

@rdlugosz
Copy link

Thx! Playing with it now. Looking good so far.

On Sun, Sep 20, 2015 at 9:07 PM, Chris Simpkins notifications@github.com
wrote:

The version 2.014 test build has tighter line spacing, in line with the
line spacing in DejaVu Sans Mono and Menlo. I get the same number of lines
as are displayed with these two fonts now. We've had a number of issue
reports about very slight vertical alignment issues between sets that
prompted this vertical metrics update. For those who like it tight, you
will likely find this build to your liking. I am waiting for more general
feedback to decide if this will be the new default. I anticipate that this
is going to address some of our Powerline and other alignment dependent
spacing issues so this may well stick.

Files are available in #111
#111

For those looking for looser builds, this is still planned.


Reply to this email directly or view it on GitHub
#28 (comment).

@chrissimpkins
Copy link
Member Author

@rdlugosz 👍 Let me know if you see any problems

@Palid
Copy link

Palid commented Sep 21, 2015

@chrissimpkins It looks great! Same vertical spaces as Menlo and looks so much better!

Also, would it be a good idea to keep all the different versions in one package? Hack-wide, hack-small, hack-normal?

@chrissimpkins
Copy link
Member Author

@Palid Glad to hear that you like the changes Dariusz. The new test build changes will be the default for Hack so I am interested in a bit more feedback to make sure that I didn't go too far to the tight end of the line spacing spectrum. It seems that there was much more interest in this than looser spacing, but we do have requests for this.

My thought would be to create new fonts for the line spacing variants and name them "Hack [something that indicates spacing here]" so that they can be installed side by side. It might be useful to use different versions in different editors where either rendering differs or you have the option to further adjust line spacing. I'm not certain that there is a standard for naming this metric in fonts and I suppose that we can come up with our own.

@rdlugosz Ryan do you have an Input font license? If so, would you be willing to help me explore how they manipulate their vertical metrics with their line spacing selector (image below)?
input-line-spacing

@chrissimpkins
Copy link
Member Author

Is anyone seeing problems with diacritic marks on any platforms / at any text sizes?

@Palid
Copy link

Palid commented Sep 21, 2015

Nothing yet, I'll give more feedback in a few days. Ending my today's coding session. ;)

@rdlugosz
Copy link

@chrissimpkins sorry, I don't have a license. I'm not actively using that font, btw... something about the feel that just isn't right for me. I just happened across it around the same time that I posted in this thread.

@chrissimpkins
Copy link
Member Author

@rdlugosz no worries. Thanks for letting me know. Did you have thoughts on the line spacing in the new version? I think you were one of the people requesting tighter spacing.

@chrissimpkins
Copy link
Member Author

Tighter vertical spacing is now available in the v2.015 release that was pushed today. Leaving this issue open to address looser spacing variants in the future.

@chrissimpkins
Copy link
Member Author

@hrj does this address your alignment issues? If not, let's split this off into a different issue report.

@hrj
Copy link

hrj commented Sep 29, 2015

@chrissimpkins Yes, it works perfectly. Thanks!

@chrissimpkins
Copy link
Member Author

@hrj great! thank you for the feedback.

@rdlugosz
Copy link

Thanks for all the hard work on this font, @chrissimpkins ! Using it as my daily driver right now and really enjoying it.

@chrissimpkins
Copy link
Member Author

@rdlugosz Great to hear that. There's been a tremendous amount of work by a large number of people here. It's good to hear that it shows.

@chrissimpkins
Copy link
Member Author

Started work on an application to address this. It will allow you to easily modify the spacing yourself. Hope to have a version that you can try in the next several days. Will post here when available.

@chrissimpkins
Copy link
Member Author

Long overdue and now available for testing by the "clown car tight" and "loosey goosey" crowds...

The initial release of the new line spacing adjustment tool is now available. Feel free to give it a try and please provide feedback on the tool repository if you encounter any issues.

More details in this new issue report: #191

@chrissimpkins
Copy link
Member Author

I’d be interested in feedback about this line spacing adjustment tool (#28 (comment)) if you have time to give it a try. I am looking into the metrics that influence line spacing on different platforms x different editors. There may be a bit of tinkering with the tool to achieve cross-platform consistency in line spacing across Linux, OS X, and Windows.

Please let me know what you think. Thanks much.

@chrissimpkins
Copy link
Member Author

Closing issue report now that the line spacing tool is available. We do not intend to modify the default line spacing or release other spacing variants at this point. Please reopen if you need and submit any issues with the tool on that repository.

@chrissimpkins chrissimpkins self-assigned this Mar 29, 2016
@chrissimpkins
Copy link
Member Author

Line spacing shell scripts are now available and automate this within the range 10 - 30% UPM size (in 5 percentage point increments). Drop the script in a directory with only your Hack fonts and execute it.

They are available here:

https://github.com/chrissimpkins/Hack/tree/master/tools/line-spacing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

8 participants