Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold brackets and braces in dev are too low #443

Closed
jdw1996 opened this issue Jul 6, 2018 · 8 comments
Closed

Bold brackets and braces in dev are too low #443

jdw1996 opened this issue Jul 6, 2018 · 8 comments

Comments

@jdw1996
Copy link
Contributor

jdw1996 commented Jul 6, 2018

It seems the centre-line of the square brackets and curly braces is lower in the bold weight than in the regular weight, in the version of the fonts currently in dev. Here's a GIF showing the difference, made using a fresh build of the fonts from dev:

hack-braces

I see the same thing when toggling between regular italics and bold italics. I'm not sure if it's a design decision or if the bold glyphs just weren't moved upward at the same time as the regular ones.

@chrissimpkins
Copy link
Member

Thanks Joseph. Linux? Assuming that you see this across our target sizes 8-14?

Will take a look. I thought that I addressed all of these when we worked on the parentheses.

@jdw1996
Copy link
Contributor Author

jdw1996 commented Jul 7, 2018

Hi Chris. Yes, this is on Xubuntu Linux. I first noticed it in code in Vim, at size 11. I can post screenshots at a smaller size tomorrow if it will help.

@chrissimpkins
Copy link
Member

Thanks. No need to post images. Just confirming. I will take a look at the design and post here when I have more information.

@chrissimpkins
Copy link
Member

You are correct! There are vertical alignment issues in both bold and bold italic sets.

Regular

hack-regular

Italic

hack-italic

Bold

hack-bold

Bold Italic

hack-bolditalic

Thanks for checking this Joseph. Will make the changes so that they are aligned...

@chrissimpkins
Copy link
Member

chrissimpkins commented Jul 18, 2018

This should be fixed as of c1f45d1 in PR #444

Want to build and confirm that you are seeing a fix on your platform?

@jdw1996
Copy link
Contributor Author

jdw1996 commented Jul 18, 2018

Hey Chris, I just rebuilt with the glyphs from the PR and it solved the issue. Thanks!

@chrissimpkins
Copy link
Member

Excellent! Thanks for reporting this. I will merge it into dev. Have been a bit tied up with other things but am anxious to get this release out soon. Thanks again for all of the work that you contributed for 4.000. Things are looking good!

@chrissimpkins
Copy link
Member

merged to dev for release as part of v4.000 release work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants