Skip to content

Commit

Permalink
Merge pull request #338 from sourcebots/test-fix
Browse files Browse the repository at this point in the history
Fix unit tests
  • Loading branch information
inventor02 committed May 7, 2024
2 parents b5c084e + ab3563b commit 93f7e02
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/test_servo_board.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def test_servo_board_identify(servoboard_serial: MockServoBoard) -> None:
assert servo_board.identify().asset_tag == "TEST456"


@pytest.mark.skip(reason="TODO update servo values")
def test_servo_board(servoboard_serial: MockServoBoard) -> None:
"""
Test that the servo board functionality works.
Expand Down Expand Up @@ -97,7 +96,6 @@ def test_servo_board(servoboard_serial: MockServoBoard) -> None:
assert servo_board.voltage == 5.432


@pytest.mark.skip(reason="TODO update servo values")
def test_servo_board_servos(servoboard_serial: MockServoBoard) -> None:
"""
Test that the servo board servo functionality works.
Expand All @@ -119,6 +117,7 @@ def test_servo_board_servos(servoboard_serial: MockServoBoard) -> None:
])
# Test that we can set the duty cycle limits
servo_board.servos[0].set_duty_limits(1000, 1100)
servo_board.servos[1].set_duty_limits(1000, 2000)

# Test that we can get the duty cycle limits
assert servo_board.servos[0].get_duty_limits() == (1000, 1100)
Expand Down

0 comments on commit 93f7e02

Please sign in to comment.