Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a less generic name than "metadata.json" #66

Closed
kierdavis opened this issue Aug 15, 2019 · 3 comments
Closed

Use a less generic name than "metadata.json" #66

kierdavis opened this issue Aug 15, 2019 · 3 comments
Assignees

Comments

@kierdavis
Copy link
Member

We have observed teams leaving other things on their robot code USB sticks, for example virtualenvs. Some packages installed into a virtualenv also contain a file named "metadata.json". If the sbot metadata search finds one of these files before it finds the one on the arena USB, the wrong file will be loaded (almost certainly not containing "zone" or "is_competition" fields), resulting in bogus MetadataKeyErrors.

We should change the filename to something more specific, e.g. "sbot-metadata.json".

@tpoomlmly tpoomlmly self-assigned this Nov 13, 2021
@tpoomlmly
Copy link
Member

At the moment sbot just checks for any .json file

@trickeydan
Copy link
Contributor

If you migrate to Astoria, it looks for
astoria-metadata.json

@tpoomlmly
Copy link
Member

Good idea; we'll do that instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants