Unclearly exit if terminating takes too long #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could happen if someone catches `BaseException`, or due to another issue with cleanup. Also add some specific test cases to catch the specific cases, which can be added to over time.
Needed to make mypy happy
RealOrangeOne
force-pushed
the
feature/improve-timeout-termination
branch
from
a363153
to
b3a261d
Compare
This ensures it doesn't block the running process
tpoomlmly
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen if someone catches
BaseException, or due to another issue with cleanup.Also add some specific test cases to catch the specific cases, which can be added to over time.
Previously, the running timer for Windows would prevent the process from terminating. This has also been fixed.
This likely requires #334 to function correctly on Windows.