Skip to content

Commit

Permalink
CI: make sure we log in for deployments (#1541)
Browse files Browse the repository at this point in the history
Over at
#1514 (comment)
I suggested adding `deploy: false` to be less surprising with the
tags we're pushing to DockerHub.

As mentioned in #1512, we actually need `publish: true` to log in
with DockerHub.
  • Loading branch information
Beanow committed Jan 10, 2020
1 parent cbdac8e commit c69439b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .circleci/config.yml
Expand Up @@ -133,7 +133,6 @@ workflows:
- test
- test_full
- test_full_10
deploy: false
image: sourcecred/sourcecred
tag: latest
extra_build_args: --cache-from=node:12,sourcecred/sourcecred:dev
Expand Down

0 comments on commit c69439b

Please sign in to comment.