Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiatives: implement "cooked HTML" template parsing #1478

Merged
merged 1 commit into from Jan 7, 2020

Conversation

Beanow
Copy link
Contributor

@Beanow Beanow commented Dec 7, 2019

Depends on #1417
This plus the #1480 PR replace the previous #1418.

Will return a partial Initiative, or throw when the template isn't matched.

Based on the template that's currently used on the forums:
https://discourse.sourcecred.io/t/about-the-initiatives-category/242

@Beanow
Copy link
Contributor Author

Beanow commented Dec 7, 2019

Missed the "considers blank status incomplete" test from previous code.

@Beanow
Copy link
Contributor Author

Beanow commented Dec 7, 2019

@decentralion @wchargin something weird going on with sharness here.
The ":(exclude,top)src/plugins/initiatives/htmlTemplate.test.js" exception is required to make a local yarn sharness or yarn test --full succeed. But the CI test passes without it.

@Beanow
Copy link
Contributor Author

Beanow commented Dec 7, 2019

Switched the DOM parsing to be synchronous. As the implementation is also synchronous, just supports streaming data if needed.

@Beanow Beanow changed the base branch from dev-initiative-type to master January 7, 2020 13:08
Will return a partial Initiative, or throw when the template
isn't matched.
@Beanow Beanow merged commit 4ab58a0 into master Jan 7, 2020
@Beanow Beanow deleted the wip/htmlTemplate branch January 7, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants