Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiatives: implement DiscourseInitiativeRepository #1483

Merged
merged 1 commit into from Jan 7, 2020

Conversation

Beanow
Copy link
Contributor

@Beanow Beanow commented Dec 8, 2019

Depends on #1477 and #1480.

Uses the Discourse mirror data and #1480 parsing function to create an InitiativeRepository implementation. Which #1477 can use for createGraph.

Test plan: yarn unit
No usage other than in tests yet.

@Beanow
Copy link
Contributor Author

Beanow commented Dec 13, 2019

Based on feedback in #1480 this now has the option to override the parseCookedHtml implementation as an option. Defaulting to the parseCookedHtml implementation we previously had a hard-coded call to.

Beanow added a commit that referenced this pull request Dec 14, 2019
These will be used for example as arguments for #1483's
DiscourseInitiativeRepositoryOptions.
Beanow added a commit that referenced this pull request Dec 14, 2019
These will be used for example as arguments for #1483's
DiscourseInitiativeRepositoryOptions.
Beanow added a commit that referenced this pull request Dec 14, 2019
These will be used for example as arguments for #1483's
DiscourseInitiativeRepositoryOptions.
Beanow added a commit that referenced this pull request Dec 23, 2019
These will be used for example as arguments for #1483's
DiscourseInitiativeRepositoryOptions.
@Beanow Beanow changed the base branch from wip/discourse-repo-base to master January 7, 2020 13:27
Beanow added a commit that referenced this pull request Jan 7, 2020
These will be used for example as arguments for #1483's
DiscourseInitiativeRepositoryOptions.
@Beanow Beanow merged commit 03d5258 into master Jan 7, 2020
@Beanow Beanow deleted the wip/discourse-repo branch January 7, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants