Remove deprecated gen-project command #1516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sourcecred init` command sets up a `sourcecred.json` file, which is currently just a serialized `Project`. This is based on work in #1496, but is non-interactive instead. This is a first step towards implementing the [instance system]. [instance system]: https://discourse.sourcecred.io/t/sourcecred-instance-system/244 Test plan: This command is thoroughly tested by sharness tests; see `sharness/test_cli_init.t`. THanks to @wchargin for help with the sharness testing.
The (untested, explicitly experimental) gen-project command is redundant with the (tested, and intended for long-term support) init command. Thus, I am removing it. Test plan: `yarn flow` passes, and `git grep gen-project` has no hits.
Beanow
approved these changes
Dec 28, 2019
teamdandelion
force-pushed
the
init-2
branch
2 times, most recently
from
0a2cc7f
to
6e47b1f
Compare
|
Closing until I prioritize #1515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (untested, explicitly experimental) gen-project command is redundant
with the (tested, and intended for long-term support) init command.
Thus, I am removing it.
Test plan:
yarn flowpasses, andgit grep gen-projecthas no hits.