Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirror: remove unnecessary shadowing #1609

Merged
merged 1 commit into from Feb 3, 2020
Merged

mirror: remove unnecessary shadowing #1609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/graphql/mirror.js
View file
Open in desktop
Expand Up @@ -1649,7 +1649,7 @@ export class Mirror {
db.prepare(
dedent`\
WITH RECURSIVE
direct_dependencies (parent_id, child_id) AS (
cte_direct_deps (parent_id, child_id) AS (
SELECT parent_id, child_id FROM links
WHERE child_id IS NOT NULL
UNION
Expand All @@ -1660,16 +1660,16 @@ export class Mirror {
ON connections.rowid = connection_entries.connection_id
WHERE child_id IS NOT NULL
),
transitive_dependencies (id) AS (
cte_transitive_deps (id) AS (
VALUES (:rootId) UNION
SELECT direct_dependencies.child_id
FROM transitive_dependencies JOIN direct_dependencies
ON transitive_dependencies.id = direct_dependencies.parent_id
SELECT cte_direct_deps.child_id
FROM cte_transitive_deps JOIN cte_direct_deps
ON cte_transitive_deps.id = cte_direct_deps.parent_id
)
INSERT INTO transitive_dependencies (id, typename)
SELECT objects.id AS id, objects.typename AS typename
FROM objects JOIN transitive_dependencies
ON objects.id = transitive_dependencies.id
FROM objects JOIN cte_transitive_deps
ON objects.id = cte_transitive_deps.id
`
).run({rootId});

Expand Down