mirror: add typename support to UpdateResults
#1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Most of the blacklisted reactions helpfully link to their original
source, but some don’t. This patch adds the missing links.
Test Plan:
The following command now prints a URL on every line:
```
<src/plugins/github/blacklistedObjectIds.js \
awk '/^[^ ]/ { p = 0 }; p { gsub(".*// ", ""); print }; /reactions/ { p = 1 }'
```
wchargin-branch: blacklist-urls
Summary: Fields in a GraphQL schema may now declare themselves as “unfaithful”, indicating that the server is known to return responses with incorrect types for that field. Future changes will teach the Mirror module to query these fields more carefully, handling such incorrect responses robustly. See the [tracking issue] and [project initiative] for details. [project initiative]: https://discourse.sourcecred.io/t/graphql-mirror-fidelity-awareness/275 [tracking issue]: #998 This change is source-compatible and data-incompatible: the APIs are backward-compatible, but the schema representation (JSON serialized form) has changed, and so the `Mirror` constructor will reject old caches. Test Plan: Unit tests included. wchargin-branch: schema-fidelity wchargin-source: 96e54473a41c416f77cc84e4b4d2221d3723b4fa
Summary: The internal `QueryPlan` structure now lists IDs of objects whose typename is to be queried. This list is expected to be empty for now. Test Plan: Unit tests included. wchargin-branch: mirror-typename-queryplan wchargin-source: ca4c04da1ec1b4795cc66eb90a5559703a7ccd58
Summary: The internal `UpdateResult` structure now lists IDs of objects whose typename has been queried. This list is expected to be empty for now. Test Plan: Unit tests added. wchargin-branch: mirror-typename-updateresult wchargin-source: 8fa7c0760901419ee5ad38d7608b9ab22d4bd6bb
wchargin-branch: blacklist-urls wchargin-source: e107c413b08f21d8efa79ca0f587a24a569eaed1
wchargin-branch: schema-fidelity wchargin-source: 61796a7a35b785a5a2efa78356da659c1fa14251
wchargin-branch: mirror-typename-queryplan wchargin-source: a556ec86b5d34aafbbacdf65c07e9acfc587b581
wchargin-branch: mirror-typename-updateresult wchargin-source: 224be876dcbfeb23715092b5735d0f59e39d88bd
wchargin-branch: schema-fidelity wchargin-source: bef16a1a6edbb3325445e941b9c6a5ef70003284
wchargin-branch: mirror-typename-queryplan wchargin-source: 82423a6797731234387ebdb7a5ba22f7da0b9d5c
wchargin-branch: mirror-typename-updateresult wchargin-source: 56e5970ca05227946b96826375793dd1c906c13b
teamdandelion
approved these changes
Feb 18, 2020
wchargin
changed the base branch from
wchargin-mirror-typename-queryplan
to
master
wchargin-branch: mirror-typename-updateresult wchargin-source: ae92efd6c2cfebbaa4c8089ed9c12f47ca117879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The internal
UpdateResultstructure now lists IDs of objects whosetypename has been queried. This list is expected to be empty for now.
Test Plan:
Unit tests added.
wchargin-branch: mirror-typename-updateresult