Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CSV grain integration production-ready #3320

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Get CSV grain integration production-ready #3320

merged 1 commit into from
Feb 11, 2022

Conversation

blueridger
Copy link
Member

@blueridger blueridger commented Feb 5, 2022

Description

This PR makes sure the CSV grain integration is ready for use. There were some minor features missing as well as some bugs that got introduced by recent changes.

  • removes the balance column from the UI when ledger accounting is disabled
  • do not write grain integration results to disk when -s flag is used
  • fixes config update writing bug
  • fixes credGrainview related bug

Test Plan

currencyDetails.json:

{
  "currencyName": "USDC",
  "currencySuffix": " USDC",
  "integrationCurrency": {
    "type": "EVM",
    "chainId": "1",
    "tokenAddress": "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48"
  }
}

grain.json:

{
  "allocationPolicies": [
    {
      "budget": "100.1234",
      "numIntervalsLookback": 8,
      "policyType": "IMMEDIATE"
    }
  ],
  "maxSimultaneousDistributions": 1,
  "integration": { "type": "csv" },
  "accountingEnabled": false
}
  1. checkout a production instance
  2. regression testing: scdev grain -f -s && scdev serve
  3. make the config changes above
  4. scdev serve
  5. identities > select identity > add payout address and save
  6. scdev credequate or scdev credrank, depending on what instance you are using
  7. scdev grain -f
  8. verify only the person with a payout address gets grain
  9. verify the csv file in ./output/grainintegration

@blueridger blueridger merged commit b5298c0 into main Feb 11, 2022
@blueridger blueridger deleted the csv-int branch February 11, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants