-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unix permissions #193
Closed
believeinlain
wants to merge
33
commits into
sourcefrog:main
from
believeinlain:add-unix-permissions
Closed
Add unix permissions #193
believeinlain
wants to merge
33
commits into
sourcefrog:main
from
believeinlain:add-unix-permissions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally got it to pass CI on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #46
unix_mode.rs
that adds metadata representing the Unix mode bits usingstd::fs::Permissions
andstd::os::unix::fs::PermissionsExt
(on unix).0o100775
, which should ideally be changed, as a more suitable default is0o664
for files and0o775
for directories. (I think the1
in0o100775
is the inode type, as in file, directory, symlink, etc., but I'm not sure). Regardless, it captures the entire unix mode so it works well on unix-like systems with newer backups.