Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar issues and smells #97

Closed
yeshamavani opened this issue Jan 3, 2024 · 1 comment · Fixed by #98
Closed

Fix sonar issues and smells #97

yeshamavani opened this issue Jan 3, 2024 · 1 comment · Fixed by #98
Assignees
@sf-sahil-jassal
Labels
released

Comments

@yeshamavani
Copy link
Contributor

Describe the bug
Fix sonar issues and smells
https://sonarcloud.io/summary/overall?id=sourcefuse_loopback4-audit-log
sf-sahil-jassal added a commit that referenced this issue Jan 9, 2024
@sf-sahil-jassal
refactor(chore): fix sonar code smells
819d67a 
fix sonar code smells related to promises, and any types

GH-97
sf-sahil-jassal added a commit that referenced this issue Jan 9, 2024
@sf-sahil-jassal
refactor(chore): resolve sonar code smell of duplicate code
4d69c45 
attempt to fix sonar code smell related to duplicate blocks
of code by refactoring the chunks of code

GH-97
@sf-sahil-jassal sf-sahil-jassal mentioned this issue Jan 9, 2024
Merged
12 tasks
sf-sahil-jassal added a commit that referenced this issue Jan 9, 2024
@sf-sahil-jassal
refactor(chore): fix sonar code smells
ce7ef97 
fix sonar code smells after new analysis related to camel case
conventions of mixins, any types and unexpected console statements

GH-97
sf-sahil-jassal added a commit that referenced this issue Jan 9, 2024
@sf-sahil-jassal
refactor(chore): reduce sonar duplicate lines of code
a229328 
reduce sonar cloud duplications by
refactoring the repeated lines of code in audit mixin

GH-97
sf-sahil-jassal added a commit that referenced this issue Jan 9, 2024
@sf-sahil-jassal
refactor(chore): reduce sonar duplicate lines of code
624a96a 
reduce sonar cloud duplications by
refactoring the repeated lines of code in audit mixin

GH-97
yeshamavani pushed a commit that referenced this issue Jan 10, 2024
@sf-sahil-jassal
refactor(chore): fix sonar code smells (#98)
8ac3dad 
* refactor(chore): fix sonar code smells

fix sonar code smells after new analysis related to camel case
conventions of mixins, any types and unexpected console statements

GH-97

* refactor(chore): reduce sonar duplicate lines of code

reduce sonar cloud duplications by
refactoring the repeated lines of code in audit mixin

GH-97
@yeshamavani
Copy link
Contributor Author

🎉 This issue has been resolved in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sf-sahil-jassal sf-sahil-jassal

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(chore): fix sonar code smells sourcefuse/loopback4-audit-log
2 participants
@yeshamavani @sf-sahil-jassal