Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): fix SAML passport authentication strategy #132

Closed
wants to merge 4 commits into from
Closed

fix(provider): fix SAML passport authentication strategy #132

wants to merge 4 commits into from

Conversation

RaghavaroraSF
Copy link
Contributor

@RaghavaroraSF RaghavaroraSF commented Jan 25, 2023 •
edited
Loading

Description

Fixed the npm version because it was deprecated

GH-131

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@RaghavaroraSF
fix(provider): fix SAML passport authentication strategy
d87d726 
Fixed the npm version because it was deprecated

GH-131
@yeshamavani
Copy link
Contributor

Rollback the changes that are not required anymore because of the library change

@RaghavaroraSF
fix(provider): fix SAML passport authentication strategy
ba726e3 
Fixed the npm version because it was deprecated

GH-131
@RaghavaroraSF
fix(provider): fix SAML passport authentication strategy
7b0f6e2 
Fixed the npm version because it was deprecated

GH-131
yeshamavani
yeshamavani reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@yeshamavani yeshamavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the docs to readme

src/strategies/SAML/saml-strategy-factory-provider.ts Show resolved Hide resolved
src/strategies/SAML/saml-strategy-factory-provider.ts Show resolved Hide resolved
@RaghavaroraSF
fix(provider): fix SAML passport authentication strategy
be55c48 
Fixed the npm version because it was deprecated

GH-131
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

yeshamavani
yeshamavani requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@yeshamavani yeshamavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the PR
Also this will go as a feature and not fix

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeshamavani yeshamavani yeshamavani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaghavaroraSF @yeshamavani