fix(component): make client password and bearer strategy as mandatory #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf-sahil-jassal
force-pushed
the
GH-209
branch
from
0b5fe05
to
e105f81
Compare
sf-sahil-jassal
changed the title
sf-sahil-jassal
force-pushed
the
GH-209
branch
from
e105f81
to
78a7a4b
Compare
sf-sahil-jassal
changed the title
yeshamavani
requested changes
Jan 15, 2024
There was a problem hiding this comment.
"./passport-bearer": {
"type": "./dist/strategies/passport/passport-bearer/index.d.ts",
"default": "./dist/strategies/passport/passport-bearer/index.js"
},
"./passport-client-password": {
"type": "./dist/strategies/passport/passport-client-password/index.d.ts",
"default": "./dist/strategies/passport/passport-client-password/index.js"
not needed should be directly exported from the package
sf-sahil-jassal
force-pushed
the
GH-209
branch
3 times, most recently
from
8d713ae
to
0015866
Compare
make client password strategy mandatory as it needs to be for any authentication by any strategy. Also, make bearer stratgey mandatory as everybody use it GH-209
|
yeshamavani
approved these changes
Jan 17, 2024
|
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make bearer strategy non optional,
resulting client password strategy also not optional
GH-209
Description
Making the bearer strategy mandatory. But, by only making the bearer as manadatory, failed in test cases. Seems like, client password strategy is also needed for the same (infact all strategies as client is always needs to be authenticated first). So, I also made client password strategy as mandatory.
Fixes #209
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: