fix(authentication-service): change in user model #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authClientIds now a string type in user model BREAKING CHANGE: it can impact user flow SFO-0
samarpan-b
reviewed
Aug 12, 2020
| @@ -552,10 +550,10 @@ export class LoginController { | |||
| }, | |||
| }, | |||
| }) | |||
| req: ResetPassword, | |||
| req: ResetPassword, | |||
There was a problem hiding this comment.
can u run prettier:fix to fix indent issues here
samarpan-b
requested changes
Aug 12, 2020
| @@ -681,7 +679,7 @@ export class LoginController { | |||
| ); | |||
| } | |||
|
|
|||
| if (user.authClientIds.indexOf(authClient.id || 0) < 0) { | |||
| if (user.authClientIds.indexOf(String(authClient.id || 0)) < 0) { | |||
There was a problem hiding this comment.
split this up on braces first then on comma then run this check over that array
| @@ -61,7 +61,7 @@ export class ResourceOwnerVerifyProvider | |||
| clientId, | |||
| }, | |||
| }); | |||
| if (!client || user.authClientIds.indexOf(client.id || 0) < 0) { | |||
| if (!client || user.authClientIds.indexOf(String(client.id || 0)) < 0) { | |||
There was a problem hiding this comment.
same as previous comment
BREAKING CHANGE: it will affect check of the auth client SFO-0
|
Kudos, SonarCloud Quality Gate passed!
|
samarpan-b
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
authClientIds now a string type in user model
BREAKING CHANGE:
User login flow is impacted if auth client id was getting used.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: