Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add countAll to get count of rows including soft deleted rows like findAll #144

Closed
irfankhan-sf opened this issue Mar 30, 2023 · 0 comments · Fixed by #145
Closed

Add countAll to get count of rows including soft deleted rows like findAll #144

irfankhan-sf opened this issue Mar 30, 2023 · 0 comments · Fixed by #145
Assignees
@shubhamp-sf
Labels
enhancement New feature or request

Comments

@irfankhan-sf
Copy link

irfankhan-sf commented Mar 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
currently we only have count function which give count of non deleted rows. so
Add countAll to get count of all rows including soft deleted rows like we have findAll includes soft deleted rows for find
@shubhamp-sf shubhamp-sf self-assigned this Apr 4, 2023
@shubhamp-sf shubhamp-sf added the enhancement New feature or request label Apr 4, 2023
shubhamp-sf added a commit that referenced this issue Apr 4, 2023
@shubhamp-sf
feat(repository): add countAll method
80c2d53 
adds countAll function in soft crud base repositories to
support counting all entries including soft deleted ones

GH-144
@shubhamp-sf shubhamp-sf mentioned this issue Apr 4, 2023
Merged
9 tasks
shubhamp-sf added a commit that referenced this issue Apr 6, 2023
@shubhamp-sf
feat(repository): add countAll method (#145)
1cc19b9 
adds countAll function in soft crud base repositories to
support counting all entries including soft deleted ones

GH-144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhamp-sf shubhamp-sf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(repository): add countAll method sourcefuse/loopback4-soft-delete
2 participants
@irfankhan-sf @shubhamp-sf