Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Can't find repo (Please remove it.) #90

Closed
ennerperez opened this issue Apr 27, 2024 · 6 comments
Closed

[BUG] - Can't find repo (Please remove it.) #90

ennerperez opened this issue Apr 27, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ennerperez
Copy link
Contributor

In the method FindRepository() instance.Repositories returns 0 even when the repo is listed:

image

And it allow to open in file browser and terminal but keep saying:

image

@ennerperez ennerperez changed the title [BUG] - Can't find repo (Repository does NOT exists any more. Please remove it.) [BUG] - Can't find repo (Please remove it.) Apr 27, 2024
@love-linger love-linger self-assigned this Apr 27, 2024
@love-linger
Copy link
Collaborator

Yes, it's designed that way. Items in the tree in Welcome page should NOT be auto-removed. Instead, it must stay where it should be to notice users that they have a invalid repository.

@love-linger love-linger added the wontfix This will not be worked on label Apr 27, 2024
@ennerperez
Copy link
Contributor Author

But it's not invalid repository, it was not deleted, I have the last release installed but when I run from source code it's detect the previous repo, but won't let me open because of this, so I have to deleted and adding again which is annoying

IDK if this is a bug in prod, or it's only because of the dual execution.

@love-linger
Copy link
Collaborator

I have reproduced this issue. Here is how I did it:

  • Make sure you have closed this app.
  • Rename the target repository manually on disk.
  • Open this app, it will check all repositories and remove those not exists on disk.
  • Rename the target repository back to it's original name.

It's because Open In Terminal and Open in File Browser do NOT check repository from Preference. Instead, it use the _id field directly.

@love-linger love-linger added bug Something isn't working and removed wontfix This will not be worked on labels Apr 28, 2024
love-linger added a commit that referenced this issue Apr 28, 2024
@love-linger
Copy link
Collaborator

love-linger commented Apr 28, 2024

Although it is not clear why your repositories list was emptied from Preference, the 32e6856 will at least alert the user that there is something wrong with this tree node and they should remove it.

@ennerperez
Copy link
Contributor Author

Still reproducible in 8.10 I just update and again I'm getting the error.

image

@ennerperez
Copy link
Contributor Author

I think is not enough, I found a workaround to my problem: #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants