Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to run program by default for macOS and Linux #107

Merged
merged 1 commit into from
May 5, 2024

Conversation

dangreene0
Copy link
Contributor

By default the compiled program will not run on macOS or Linux and the user must use chmod to enable the ability to execute.

By adding another step in the jobs for macOS and Linux the artifact will now run when the user downloads.

c7784b0

@love-linger love-linger merged commit 16741c2 into sourcegit-scm:develop May 5, 2024
@dangreene0
Copy link
Contributor Author

dangreene0 commented May 5, 2024

Thanks for the merge!

After testing this, it seems to not have worked and is probably a perms issue.
I will possibly look into it more and test it before following up with another PR.

@gadfly3173
Copy link
Contributor

actions/upload-artifact@v4 will package product files into zip, and zip does not support permission management. To solve this problem, you need to package it yourself through tar.
https://github.com/actions/upload-artifact#permission-loss

- name: 'Tar files'
  run: tar -cvf my_files.tar /path/to/my/directory

- name: 'Upload Artifact'
  uses: actions/upload-artifact@v4
  with:
    name: my-artifact
    path: my_files.tar

@dangreene0
Copy link
Contributor Author

actions/upload-artifact@v4 will package product files into zip, and zip does not support permission management. To solve this problem, you need to package it yourself through tar. https://github.com/actions/upload-artifact#permission-loss

- name: 'Tar files'
  run: tar -cvf my_files.tar /path/to/my/directory

- name: 'Upload Artifact'
  uses: actions/upload-artifact@v4
  with:
    name: my-artifact
    path: my_files.tar

Thanks for the reply. I found this out through a Post on StackOverflow and I'm working on a PR shortly.

It sure is a strange quirk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants