-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open in... #33
Open in... #33
Conversation
I've tested your PR. The functionality is complete. But using the So, I suggest use PNG instead of SVG for this PR. |
* use PNG instead of SVG for external tool icons and remove dependency `Avalonia.SVG` * remove unused property `IsVSCodeFound` and `IsFleetFound` * find VS from registry first * remove compile warning CA1416 * remove unused enum `OS.Platforms`
There is a file size limit for the final exe? I think the usage of Avalonia.Svg worth it. specially to improve the UI, add new icons, and make it scalable for different resolutions, I have to test it in high DPI resolution when probably PNG quality is not good enough. |
No, there's no limitations for the size of final exe. But in this project, SVG only used to display the external editor icons. I think it's not worth to introduce a new package since we can use |
What happened with the menu? |
Now, only external tools detected by the software are displayed. |
Contextual menu to "Open with actions..."