Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in... #33

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

ennerperez
Copy link
Contributor

Contextual menu to "Open with actions..."

image

  • Open in Fleet
  • Open in Visual Studio Code

@love-linger
Copy link
Collaborator

I've tested your PR. The functionality is complete.

But using the Avalonia.Svg increase the size for final exe from 37MB to 42MB! Then I converts these two SVG icon to PNG image with 64x64 size and removed reference for Avalonia.SVG. After that the size of
final exe comes back to 37MB.

So, I suggest use PNG instead of SVG for this PR.

love-linger added a commit that referenced this pull request Mar 28, 2024
* use PNG instead of SVG for external tool icons and remove dependency `Avalonia.SVG`
* remove unused property `IsVSCodeFound` and `IsFleetFound`
* find VS from registry first
* remove compile warning CA1416
* remove unused enum `OS.Platforms`
love-linger added a commit that referenced this pull request Mar 28, 2024
@love-linger love-linger merged commit 370b9bd into sourcegit-scm:master Mar 28, 2024
4 checks passed
@ennerperez
Copy link
Contributor Author

There is a file size limit for the final exe? I think the usage of Avalonia.Svg worth it. specially to improve the UI, add new icons, and make it scalable for different resolutions, I have to test it in high DPI resolution when probably PNG quality is not good enough.

@love-linger
Copy link
Collaborator

There is a file size limit for the final exe? I think the usage of Avalonia.Svg worth it. specially to improve the UI, add new icons, and make it scalable for different resolutions, I have to test it in high DPI resolution when probably PNG quality is not good enough.

No, there's no limitations for the size of final exe. But in this project, SVG only used to display the external editor icons. I think it's not worth to introduce a new package since we can use RenderOptions.BitmapInterpolationMode="HighQuality" to get a similar result with built-in PNG support.

@ennerperez
Copy link
Contributor Author

What happened with the menu?

@love-linger
Copy link
Collaborator

Now, only external tools detected by the software are displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants