-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icon styling #5432
Comments
In alignment with the Figmas, we can use this ticket to implement a consolidated icon library. I am gathering Tracey's feedback here, otherwise, this is nearly ready for review. |
Documenting a discussion with @traceyljohnson: Initially, we proposed react-icon library for consolidation and consistency. However, brand design would like to align About with the product by focusing on Sharp-style Material icons. Some icons used in new Figma prototypes are not present in react-icon. Because we are focusing on Material icons in the future, it seems we can opt for the MUI library (search, npm) instead of a larger library.
@bretthayes @st0nebraker: What are your thoughts? I recognize that this choice has tradeoffs, so I am open to alternatives. |
I think that's a great idea to align brand between our CPT web properties and the product. Having brand consistency throughout all of our codebases would be a fantastic alignment! @traceyljohnson @zlonko Would you mind looking into the bundle size that MUI brings and if there's any dependencies other than the Something to think about is standardizing our common import { Icon } from '@components'
<Icon name="CheckCircle" size={48} /> What do you think? |
Sure thing, @bretthayes, I will look into the bundle size and possible dependencies. I agree that we should have an |
@bretthayes I dug in a little more and it looks like A little confusing: the search console actually links to @mui/icons-material and not According to next/bundle-analyzer, it is also humongous compared to
|
Oh wow! That's quite a big difference! We should investigate how to refine that and also test to make sure tree shaking is working for our production builds. Afaik, Next.js and MUI both support tree shaking so only the imported icons should be added to the bundle size. Is this a dev build or a prod build? Something seems off here, so there may be some config involved.
It looks like the |
I think we should re-consider not using MUI and look for a lighter UI library to use because it's causing rendering problems and bloat in our repo with the extra dependencies. The whole site is loading much slower now and I don't want this to reduce the performance of the site after all the hard work we've done to increase performance. @traceyljohnson can we look into alternative UI libraries together? |
@bretthayes Yeah, that's no good. Let me know what I can do to help! |
Just following up on this with some context. We have the In order to complete this ticket and instead of the previous approach of importing all icons, we should instead:
|
Update the icon library we use on the platform (maybe)
Update the styling of all icons on the platform:
Example of new styling: https://www.figma.com/file/o1QRtdQI0ozKq0n7ATrKlx/Brand-DLS?node-id=7341%3A49748
The text was updated successfully, but these errors were encountered: