Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

fix: a race condition causing settings to be overwritten #92

Merged
merged 1 commit into from Aug 24, 2018
Merged

fix: a race condition causing settings to be overwritten #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/backend/extensions.ts
View file
Open in desktop
Expand Up @@ -163,7 +163,11 @@ export function createExtensionsContextController(
if (args.edit) {
clientSettings = applyEdits(
clientSettings,
setProperty(clientSettings, args.edit.path, args.edit.value, format)
// TODO(chris): remove `.slice()` (which guards against
// mutation) once
// https://github.com/Microsoft/node-jsonc-parser/pull/12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we are using a fork by @sqs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing new in the fork microsoft/node-jsonc-parser@master...sqs:master

// is merged in.
setProperty(clientSettings, args.edit.path.slice(), args.edit.value, format)
)
} else if (typeof args.enabled === 'boolean') {
clientSettings = applyEdits(
Expand Down