This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Add find-implementations #683

Merged

chrismwendt merged 26 commits into master from impls

Nov 5, 2021

Contributor

chrismwendt commented Sep 14, 2021 •

edited

TODO

Pagination
Only show the "Find implementations" button when Sourcegraph instance has an implementations GraphQL endpoint
Merge codeintel: add support for find-implementations sourcegraph#24854 first, then update yarn.lock with sourcegraph@25.4.0
Make sure that the rangesQuery doesn't error on older sourcegraph versions.
Merge feat: support extension API v25.4.0 extension-api-stubs#167

chrismwendt force-pushed the impls branch from f045911 to d5fe718 Compare

September 14, 2021 17:51

chrismwendt mentioned this pull request

Find implementations for Go sourcegraph/sourcegraph#24479

Closed

8 tasks

tjdevries reviewed

View reviewed changes

template/src/language.ts Outdated Show resolved Hide resolved

chrismwendt force-pushed the impls branch from 93da614 to a868aae Compare

October 7, 2021 16:42

tjdevries commented Oct 12, 2021

TODO: Don't forget to short circuit for too-old sourcegraph versions

chrismwendt force-pushed the impls branch 2 times, most recently from ab4a82d to de3f01f Compare

October 18, 2021 01:47

efritz reviewed

View reviewed changes

template/src/util/api.ts Show resolved Hide resolved

efritz reviewed

View reviewed changes

template/src/providers.ts Show resolved Hide resolved

efritz reviewed

View reviewed changes

template/src/providers.ts Show resolved Hide resolved

efritz reviewed

View reviewed changes

template/src/lsif/providers.test.ts Show resolved Hide resolved

efritz reviewed

View reviewed changes

template/src/extension.ts Outdated Show resolved Hide resolved

efritz reviewed

View reviewed changes

template/src/lsif/providers.ts Show resolved Hide resolved

chrismwendt force-pushed the impls branch 3 times, most recently from 68f7063 to f27a092 Compare

October 27, 2021 18:30

chrismwendt force-pushed the impls branch from ed4b0e1 to 7d2e2e4 Compare

November 4, 2021 21:01

chrismwendt marked this pull request as ready for review

November 4, 2021 21:01

chrismwendt requested a review from a team as a code owner

November 4, 2021 21:01

chrismwendt force-pushed the impls branch from 7d2e2e4 to 09521e4 Compare

November 5, 2021 20:23

chrismwendt and others added 10 commits

November 5, 2021 14:35

wip

dcc1633


          fix conditionals

41a7f68


          use a location provider rather than an implementation provider

d49a7fc


          wip: Start to fix npm run test

d0cb06d


          wip: refactor implementations and references to some shared code

aadfcef


          nit: dont export stuff that doesn't need to be

507463c


          actually, it is correct to not return anything

856559b


          update yarn and other things

a850e9b


          fix: Only create impl panel once

ece8d40


          fix: Do not show impls panel if old sg

cb4effc

tjdevries and others added 14 commits

November 5, 2021 14:35


          fixup: remove ts-ignore by casting... just as bad LUL

556f445


          wip: Start to make this work for published extensions

c90c8b0


          use selector when creating the implementations panel

06e03d9


          fix panel IDs

5c4a482


          catch

276b119


          temporarily use old sourcegraph version to get CI checks to work

17b51a0


          lint+format

3f292f3


          update GraphQL schema from branch


          only show implementations button when there's a definition

059884e


          only request implementations if GraphQL supports implementations when…

e5af082

… preloading ranges


          only show "Find implementations" button when there's a definition

1c9aac2


          bump sourcegraph to 25.4.0

25bf28e


          update graphql schema to include implementations

2ec1eea


          bump @sourcegraph/extension-api-stubs to 1.6.0

264aeaa

chrismwendt force-pushed the impls branch from 09521e4 to 264aeaa Compare

November 5, 2021 20:37

chrismwendt added 2 commits

November 5, 2021 14:50


          fix yarn-deduplicate with: yarn upgrade graphql 15.5.3

b5f0e37


          yarn run prettier

167fa10

chrismwendt enabled auto-merge (squash)

November 5, 2021 20:52

chrismwendt merged commit 1b19eb6 into master

chrismwendt deleted the impls branch

November 5, 2021 20:52

chrismwendt mentioned this pull request

fix LANGID #717

Merged

chrismwendt mentioned this pull request

Only show "Find implementations" for languages that support it #724

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.