Skip to content

Commit

Permalink
only allow 1 retry for flaky e2e tests
Browse files Browse the repository at this point in the history
This will mean more annoying e2e failures due to flakiness in our PRs, which is bad. But it, along with #3446, will mean that we (if we are good people :) will notice the flakiness better and will fix it, thereby making it so we don't need to wait for multiple retries of some flaky tests on each build, thereby saving us time overall.
  • Loading branch information
sqs committed Mar 18, 2024
1 parent 5abac6a commit 90c8fc4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions vscode/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ const isWin = process.platform.startsWith('win')

export default defineConfig({
workers: 1,
// Give failing tests more chances
retries: isWin ? 4 : 2,
retries: 1, // give flaky tests 1 more chance, but we should fix flakiness when we see it
testDir: 'test/e2e',
timeout: isWin ? 30000 : 20000,
expect: {
Expand Down

0 comments on commit 90c8fc4

Please sign in to comment.