send sigkill to symf when extension exits (#2225)

Fix #1877
sourcegraph · Dec 8, 2023 · 977e19b · 977e19b
1 parent afdcb37
commit 977e19b
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/vscode/src/local-context/symf.ts b/vscode/src/local-context/symf.ts
@@ -273,6 +273,7 @@ export class SymfRunner implements IndexedKeywordContextFetcher, vscode.Disposab
         }
 
         let wasCancelled = false
+        let onExit: (() => void) | undefined
         try {
             const proc = spawn(symfPath, ['--index-root', tmpIndexDir, 'add', scopeDir], {
                 env: {
@@ -282,6 +283,10 @@ export class SymfRunner implements IndexedKeywordContextFetcher, vscode.Disposab
                 stdio: ['ignore', 'ignore', 'ignore'],
                 timeout: 1000 * 60 * 10, // timeout in 10 minutes
             })
+            onExit = () => {
+                proc.kill('SIGKILL')
+            }
+            process.on('exit', onExit)
 
             if (cancellationToken.isCancellationRequested) {
                 wasCancelled = true
@@ -314,6 +319,9 @@ export class SymfRunner implements IndexedKeywordContextFetcher, vscode.Disposab
             }
             throw toSymfError(error)
         } finally {
+            if (onExit) {
+                process.removeListener('exit', onExit)
+            }
             disposeOnFinish.forEach(d => d.dispose())
             await rm(tmpIndexDir, { recursive: true, force: true })
         }