[Cody Ignore] Fix risks arising from file based .cody/ignore

[dominiccooney]

There's a file-based .cody/ignore feature, there's an remote configured Cody Ignore feature planned for Enterprise, we need to make these coherent. This records clean-up while reviewing the VSCode, extension code:

☢️ risk 👷 integrating new requirements w/ existing codegm 💪 defensive, mitigation 🧹 clean up

Tasks

Beta Give feedback

1. ☢️ getContextFileFromDirectory, callers searches current directory without consulting cody ignore; passed thru edit user context files
2. ☢️ getWorkspaceFilesContext searches workspace without consulting Cody Ignore
3. ☢️ vscode/src/edit/prompt/context.ts getContext passes thru "user" context without checking Cody Ignore
4. ☢️ vscode/src/editor/vscode-editor.ts getTextEditorContextForFile does not check Cody Ignore
5. 👷 Expand ignore concept to repos, eg vscode/src/chat/ContextProvider.ts updateCodebaseContext should filter ignored repos
6. 💪 Security review
7. 💪 Audit uses of VSCode document getText, etc.
8. 💪 vscode/src/prompt/index.ts buildInteraction uses fixup file URI without checking ignore, strengthen this
9. 💪 Consider carrying file, editor content substrings in objects, not strings; use template literals for concatenation preserving taint.
10. 🧹 vscode/src/editor/active-editor.ts caches lastActiveTextEditor for no purpose (the cache is effective, via getEditor)
11. 🧹 check/isCodyIgnoredFile is unused (at least in JetBrains) in Agent protocol, so remove it; API as designed is weird (takes a list of files, returns a single boolean) and wasteful (checks all of the files to return true even if the first file is true)
12. 🧹 There are "chat based" and "new" edit, unit test commands. Minimize risk by deprecating, removing unused commands.
13. What's the plan for context? Do we require user prompts to be promptstring?
14. PromptString: Revisit the type for storing references. Add PromptString #3734 (comment)
15. PromptString: Handle serialization of chat transcriptions with a resolved reference.
16. PromptString: Can we guarantee that filters are honored? Cody Ignore: Check reference violations at I/O boundaries #3856 (comment)

[abeatrix]

@dominiccooney For the ☢️ items, IIRC we removed isCodyIgnored checks from those on purpose because we have moved them to the prompt constructing step in SimpleChatModel and prompt-builder where context will be filtered before the request is sent to the LLM for chat and commands

Edit: not saying that was right though. just wanted to provide some context 😃

[dominiccooney]

@abeatrix thanks for the pointers, I have moderated the language in the issue a bit—defects to risks, etc.

We still need to clean this up, because it relies on really long range dependencies lining up and staying aligned. For example, if EditManager.executeEdit are passed configuration.document that doesn't belong to the active editor, then we check whether the editor is ignored, but I believe we can pass the document+selection down to buildGenericPrompt and put the selection in the instruction.