Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified onboarding experiment assignment and logging #1036

Merged
merged 9 commits into from
Sep 14, 2023
Merged

Simplified onboarding experiment assignment and logging #1036

merged 9 commits into from
Sep 14, 2023

Commits on Sep 14, 2023

  1. Move shared onboarding experiment types into protocol.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    efccc37 View commit details
    Browse the repository at this point in the history

  2. Simplified onboarding experiment selection and logging.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6f2ee93 View commit details
    Browse the repository at this point in the history

  3. Log the JSON serialization of some objects to avoid [Object object]

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    77b71d3 View commit details
    Browse the repository at this point in the history

  4. Assign 50% to the treatment arm.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    dd372f4 View commit details
    Browse the repository at this point in the history

  5. Update tests to handle non-zero experiment roll out.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5179f7c View commit details
    Browse the repository at this point in the history

  6. Update changelog.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    14f46de View commit details
    Browse the repository at this point in the history

  7. Exclude VScode web UI users from the experiment.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    040b872 View commit details
    Browse the repository at this point in the history

  8. Update ad-hoc vscode mocks to include UIKind.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9d279c3 View commit details
    Browse the repository at this point in the history

  9. Feedback: Less log spam. Add TODO about TelemetryService passing.

    @dominiccooney
    dominiccooney committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    daf9101 View commit details
    Browse the repository at this point in the history