Autocomplete: Fix cody-autocomplete-claude-instant-infill experiment #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
approved these changes
Sep 21, 2023
philipp-spiess
added a commit
that referenced
this pull request
Sep 21, 2023
…1132) Seems like there was a conflict between @abeatrix's addition of the feature flag and @taras-yemets' restructurings. The result of `resolveDefaultProviderFromVSCodeConfigOrFeatureFlags` was no longer used for the Anthropic initialization causing users to load the wrong prompt mode if `cody-autocomplete-claude-instant-infill` is enabled. ## Test plan - Make sure you are connected to doctom - Be in the control group of the StarCoder experiment (needs dotcom admin access) - Ensure no model or provider overwrites are active - Observe that the right mode is loaded <img width="962" alt="Screenshot 2023-09-21 at 15 16 22" src="https://github.com/sourcegraph/cody/assets/458591/28ea32de-dd8d-41e0-8672-0f8680771514"> <!-- Required. See https://docs.sourcegraph.com/dev/background-information/testing_principles. -->
|
Thank you, @philipp-spiess! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there was a conflict between @abeatrix's addition of the feature flag and @taras-yemets' restructurings. The result of
resolveDefaultProviderFromVSCodeConfigOrFeatureFlagswas no longer used for the Anthropic initialization causing users to load the wrong prompt mode ifcody-autocomplete-claude-instant-infillis enabled.Test plan